fix: avoid scrolling into view for mouse interactions. #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
microbit-matt-hillsdon
force-pushed
the
scroll-into-view-tweak
branch
from
d15ab75 to
0b25550
Compare
rachel-fenichel
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
I added a video of the previous behaviour to the issue.
@microbit-grace also discovered that right clicking on a block that was moved by scroll into view closed the context menu so that's another reason not to do this for mouse interactions.
Alternatives: I did consider moving this to explicit code in the actions but it seems easy to miss keyboard nav cases that way (e.g. non directional actions that change the cursor like delete).